fix: attestation verification for repos that re-use amp-devcontainer workflows#987
Merged
Merged
Conversation
…evcontainer workflows
Contributor
There was a problem hiding this comment.
Pull Request Overview
Adds explicit signer workflow reference to attestation verification so downstream repositories using the reusable build/push workflow can successfully verify image attestations.
- Introduces --signer-workflow flag to gh attestation verify command.
- Targets canonical workflow path to align verification with reusable workflow origin.
|
Contributor
📦 Container Size AnalysisNote Comparing 📈 Size Comparison Table
|
Contributor
✅MegaLinter analysis: Success
See detailed reports in MegaLinter artifacts Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining
|
Contributor
📦 Container Size AnalysisNote Comparing 📈 Size Comparison Table
|
Contributor
Ron (rjaegers)
changed the title
Ron (rjaegers)
changed the title
EkelmansPh
approved these changes
Oct 21, 2025
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Oct 21, 2025
…workflows (#987) fix: enable attestation verification to pass for repos that use amp-devcontainer workflows
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Ron (rjaegers)
deleted the
fix/attestation-verification-for-other-repo
branch
Contributor
Pull Request Report (#987)Static measures
Time related measures
Status check related measures
|
Contributor
|
🎉 Hooray! The changes in this pull request went live with the release of v6.5.2 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Hey, I have created a Pull Request
Description of changes
This pull request updates the attestation verification step in the
.github/workflows/wc-build-push.ymlworkflow to improve security and traceability.Security and attestation verification:
Verify attestationstep now explicitly specifies the--signer-workflowparameter, referencing thephilips-software/amp-devcontainer/.github/workflows/wc-build-push.ymlworkflow for signer verification. This ensures that attestations are only accepted from trusted workflows and enhances the provenance of built images.✔️ Checklist